Sm/simplify-message-imports #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Dec 8, 2023
mshanemc
commented
Dec 13, 2023
| @@ -0,0 +1,101 @@ | |||
| /* | |||
There was a problem hiding this comment.
ahh, the actual rule that led to this PR
mdonnalley
approved these changes
Dec 14, 2023
|
QA: (used 🟢 existing uses of import { dirname } from 'node:path';
import url from 'node:url';
Messages.importMessagesDirectory(dirname(url.fileURLToPath(import.meta.url))); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This willl help roll it out everywhere.
@W-14626332@
CI 🔴 🟢 explanation:
the ones with
--fixin the name are the "what would happen when devScripts runslint --fixeverywhere.the ones without
--fixfail when any change would be made (helps verify the expected errors are thrown)packaging is green for both because it's not on ESM
This PR also moves the linter rules to eslint6 to align with everything else. There were some deprecations, including the method for getting sourceCode for the file, which is a lot of the PR noise.
the API changed some for the rule config (error, warn) => (recommended, strict, stylistic)
the imports/utils all got reorganized because (I think ESM, or at least module:node16 etc)